Align devcontainer configuration with readme#7
Merged
Conversation
squadgazzz
approved these changes
Jun 2, 2025
anxolin
reviewed
Jun 6, 2025
| "image": "mcr.microsoft.com/devcontainers/base:1", | ||
| "features": { | ||
| "ghcr.io/nlordell/features/foundry": {}, | ||
| "ghcr.io/nlordell/features/foundry": { |
There was a problem hiding this comment.
It's this using nicks's image? sholdn't this be pointing to one official repository or repo controlled by us?
Contributor
Author
There was a problem hiding this comment.
There's no official repo afaik. I agree we should change this at some point. We could either try to contact the Foundry team and ask if they are interested in supporting it or have an unofficial version under cowprotocol.
Contributor
Author
|
I tried to build again and it appears to be working. I used
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The readme specifies the Foundry version to use for the deployment.
This PR hardcodes the Foundry version in the devcontainer to that in the readme as specified in the feature usage.
I also update the base image from
0to1to make the container work with more up-to-date Foundry versions. Otherwise,forgefailes to run because there are no compatible GLIBC versions available.How to test
forge --versionin the new devcontainer. Expected output: